Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ci(release): update github release action#156

Merged
tmac1973 merged 5 commits into
mainlacework/python-sdk:mainfrom
tmacdonald/GROW-2746/semantic-release-actionlacework/python-sdk:tmacdonald/GROW-2746/semantic-release-actionCopy head branch name to clipboard
Feb 8, 2024
Merged

ci(release): update github release action#156
tmac1973 merged 5 commits into
mainlacework/python-sdk:mainfrom
tmacdonald/GROW-2746/semantic-release-actionlacework/python-sdk:tmacdonald/GROW-2746/semantic-release-actionCopy head branch name to clipboard

Conversation

@tmac1973
Copy link
Copy Markdown
Contributor

@tmac1973 tmac1973 commented Feb 6, 2024

Switch from using the python-semantic-release action to running it in a script.

Issue:

https://lacework.atlassian.net/browse/GROW-2746

@tmac1973 tmac1973 requested a review from a team as a code owner February 6, 2024 22:13
Copy link
Copy Markdown
Contributor

@ipcrm ipcrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; not sure about that git user

Comment thread .github/workflows/python-release.yml Outdated
Comment thread .github/workflows/python-release.yml Outdated
@tmac1973 tmac1973 force-pushed the tmacdonald/GROW-2746/semantic-release-action branch from 8431725 to e88c841 Compare February 7, 2024 17:15
Timothy MacDonald added 2 commits February 7, 2024 11:19
Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
@tmac1973 tmac1973 requested a review from ipcrm February 7, 2024 17:44
Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
@tmac1973 tmac1973 force-pushed the tmacdonald/GROW-2746/semantic-release-action branch from 4bc41e3 to 2715a41 Compare February 8, 2024 18:12
Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
Copy link
Copy Markdown
Contributor

@ipcrm ipcrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
@tmac1973 tmac1973 merged commit da1f4d8 into main Feb 8, 2024
@tmac1973 tmac1973 deleted the tmacdonald/GROW-2746/semantic-release-action branch February 8, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.