test: testing alert close requires open alerts #151
Merged
tmac1973 merged 2 commits intoJan 31, 2024
mainlacework/python-sdk:mainfrom
tmacdonald/GROW-2664/fix-flaky-testslacework/python-sdk:tmacdonald/GROW-2664/fix-flaky-testsCopy head branch name to clipboard
Merged
test: testing alert close requires open alerts #151tmac1973 merged 2 commits intomainlacework/python-sdk:mainfrom tmacdonald/GROW-2664/fix-flaky-testslacework/python-sdk:tmacdonald/GROW-2664/fix-flaky-testsCopy head branch name to clipboard
tmac1973 merged 2 commits into
mainlacework/python-sdk:mainfrom
tmacdonald/GROW-2664/fix-flaky-testslacework/python-sdk:tmacdonald/GROW-2664/fix-flaky-testsCopy head branch name to clipboard
Conversation
added 2 commits
January 29, 2024 16:33
get_by_guid failing due to most alert guids not supporting timeline scope Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
Add logic to make sure an open alert exists Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
PengyuanZhao
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cannot test closing an alert if no open alerts exist.
Issue:
https://lacework.atlassian.net/browse/GROW-2664