fix: Search class passes kwargs to pagination GET#144
Merged
tmac1973 merged 1 commit intoJan 12, 2024
mainlacework/python-sdk:mainfrom
tmacdonald/GROW-2675/fix-search-classlacework/python-sdk:tmacdonald/GROW-2675/fix-search-classCopy head branch name to clipboard
Merged
fix: Search class passes kwargs to pagination GET#144tmac1973 merged 1 commit intomainlacework/python-sdk:mainfrom tmacdonald/GROW-2675/fix-search-classlacework/python-sdk:tmacdonald/GROW-2675/fix-search-classCopy head branch name to clipboard
tmac1973 merged 1 commit into
mainlacework/python-sdk:mainfrom
tmacdonald/GROW-2675/fix-search-classlacework/python-sdk:tmacdonald/GROW-2675/fix-search-classCopy head branch name to clipboard
Conversation
kwargs are not passed to initial POST but are passed to subsequent pagination GET calls, causing crashes. Remove kwargs since they were never implemented in a working state for the search method. Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
ipcrm
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kwargs are not passed to initial POST but are passed to subsequent pagination GET calls, causing crashes. Remove kwargs since they were never implemented in a working state for the search method.
Issue:
https://lacework.atlassian.net/browse/GROW-2684