refactor: Make base classmethods private#142
Merged
tmac1973 merged 2 commits intoJan 10, 2024
mainlacework/python-sdk:mainfrom
tmacdonald/GROW-2671/make-base-classmethods-privatelacework/python-sdk:tmacdonald/GROW-2671/make-base-classmethods-privateCopy head branch name to clipboard
Merged
refactor: Make base classmethods private#142tmac1973 merged 2 commits intomainlacework/python-sdk:mainfrom tmacdonald/GROW-2671/make-base-classmethods-privatelacework/python-sdk:tmacdonald/GROW-2671/make-base-classmethods-privateCopy head branch name to clipboard
tmac1973 merged 2 commits into
mainlacework/python-sdk:mainfrom
tmacdonald/GROW-2671/make-base-classmethods-privatelacework/python-sdk:tmacdonald/GROW-2671/make-base-classmethods-privateCopy head branch name to clipboard
Conversation
These should have been private. This change fixes this which is required for the auto api doc generator to keep these methods out of the API docs. Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
ipcrm
reviewed
Jan 10, 2024
Contributor
ipcrm
left a comment
There was a problem hiding this comment.
Looks good!
What do we need to do here, if anything, about versioning of this project given these were public. If existing code (outside this project) is using BaseEndpoint this is going to cause some things to break, correct?
Marking these as private requires a major version change Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
ipcrm
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These should have been private. This change fixes this which is required for the auto api doc generator to keep these methods out of the API docs.
Testing:
Ran tests locally, all passed
Issue:
https://lacework.atlassian.net/browse/GROW-2671