test: add docstring linting and move to separate action#138
Merged
tmac1973 merged 4 commits intoDec 29, 2023
mainlacework/python-sdk:mainfrom
tmacdonald/GROW-2625/automatic-docstring-lintinglacework/python-sdk:tmacdonald/GROW-2625/automatic-docstring-lintingCopy head branch name to clipboard
Merged
test: add docstring linting and move to separate action#138tmac1973 merged 4 commits intomainlacework/python-sdk:mainfrom tmacdonald/GROW-2625/automatic-docstring-lintinglacework/python-sdk:tmacdonald/GROW-2625/automatic-docstring-lintingCopy head branch name to clipboard
tmac1973 merged 4 commits into
mainlacework/python-sdk:mainfrom
tmacdonald/GROW-2625/automatic-docstring-lintinglacework/python-sdk:tmacdonald/GROW-2625/automatic-docstring-lintingCopy head branch name to clipboard
Conversation
added 3 commits
December 28, 2023 13:09
using ruff Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
Contributor
Author
|
NOTE: The linting test is expected to fail here. I've got a separate issue to fix all of the docstrings. |
Signed-off-by: Timothy MacDonald <tim.macdonald@lacework.net>
PengyuanZhao
approved these changes
Dec 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add ruff docstring linting and create GH action to lint for all pushes, not just for PRs and nightlies
Issue:
https://lacework.atlassian.net/browse/GROW-2625