feat: add support for TeamUsers and UserGroups APIs#114
Merged
alannix-lw merged 1 commit intoFeb 28, 2023
mainlacework/python-sdk:mainfrom
ipcrm/user-mgmt/team-userslacework/python-sdk:ipcrm/user-mgmt/team-usersCopy head branch name to clipboard
Merged
feat: add support for TeamUsers and UserGroups APIs#114alannix-lw merged 1 commit intomainlacework/python-sdk:mainfrom ipcrm/user-mgmt/team-userslacework/python-sdk:ipcrm/user-mgmt/team-usersCopy head branch name to clipboard
alannix-lw merged 1 commit into
mainlacework/python-sdk:mainfrom
ipcrm/user-mgmt/team-userslacework/python-sdk:ipcrm/user-mgmt/team-usersCopy head branch name to clipboard
Conversation
Contributor
Author
|
@alannix-lw apologies for the jumping around, all of the fixes requested on #113 have been implemented here. |
Contributor
Author
|
Tests failed because the user getting created to test user_groups add/modify is not random so there's a race condition between them. Will fix. |
31bfa62 to
274410b
Compare
Enable managing users with the new, experimental, TeamUsers and UserGroups API
274410b to
b49c64d
Compare
alannix-lw
approved these changes
Feb 28, 2023
Contributor
alannix-lw
left a comment
There was a problem hiding this comment.
This looks great @ipcrm! I see the failed tests are just for ContractInfo which has been flaky lately, so I'm comfortable with merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable managing users with the new, experimental, TeamUsers and UserGroups API