Open
Use enums for execution/review statuses#392
Conversation
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 3a74dfa in 1 minute and 14 seconds. Click for details.
- Reviewed
109lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. backend/src/main/kotlin/dev/kviklet/kviklet/db/ExecutionRequest.kt:100
- Draft comment:
Mapping changes: now passing the enum objects directly (executionStatus and reviewStatus) instead of using .name. Ensure that JSON serialization/deserialization for these enums remains consistent with API expectations. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to ensure that JSON serialization/deserialization remains consistent, which is a form of asking the author to double-check their work. This violates the rule against asking the author to ensure behavior is intended or tested.
2. backend/src/main/kotlin/dev/kviklet/kviklet/service/dto/ExecutionRequest.kt:52
- Draft comment:
DTO update: executionStatus and reviewStatus are now defined as enums instead of strings. This enhances type safety, but ensure consumers of the API are updated if they relied on string values. - Reason this comment was not posted:
Comment looked like it was already resolved.
3. backend/src/test/kotlin/dev/kviklet/kviklet/helper/ExecutionRequestFactory.kt:157
- Draft comment:
Test factory updated: default values for executionStatus (now EXECUTABLE) and reviewStatus (AWAITING_APPROVAL) have been changed. Verify that these defaults align with the intended business logic. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify if the changes align with the intended business logic, which is against the rules. It does not provide a specific suggestion or ask for a specific test to be written. Therefore, it should be removed.
Workflow ID: wflow_K6JjmQQCE38zhub4
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Important
Change
ExecutionRequestDTOs and related classes to use enums forExecutionStatusandReviewStatusinstead of strings.ExecutionRequestDTOs to useExecutionStatusandReviewStatusenums instead of strings.ExecutionRequestAdapterto map and handle these enums.ExecutionRequestinExecutionRequest.ktto use enums forexecutionStatusandreviewStatus.DatasourceExecutionRequestandKubernetesExecutionRequestto use enums.ExecutionRequestEntityinExecutionRequest.ktto use enums forexecutionStatusandreviewStatus.ExecutionRequestFactoryinExecutionRequestFactory.ktto use enums forexecutionStatusandreviewStatus.This description was created by
for 3a74dfa. You can customize this summary. It will automatically update as commits are pushed.