Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 16, 2019. It is now read-only.

Fix ExpectedVersion#34

Open
prolic wants to merge 1 commit into
kurrent-io:masterkurrent-io/ClientAPI.NetCore:masterfrom
prolic:patch-1prolic/ClientAPI.NetCore:patch-1Copy head branch name to clipboard
Open

Fix ExpectedVersion#34
prolic wants to merge 1 commit into
kurrent-io:masterkurrent-io/ClientAPI.NetCore:masterfrom
prolic:patch-1prolic/ClientAPI.NetCore:patch-1Copy head branch name to clipboard

Conversation

@prolic

@prolic prolic commented Jul 8, 2018

Copy link
Copy Markdown

EmptyStream is 0, add missing Invalid

EmptyStream is 0, add missing Invalid
@Narvalex

Narvalex commented Jul 9, 2018

Copy link
Copy Markdown

Isn´t the stream version zero based? Why change -1 to 0?

@prolic

prolic commented Jul 9, 2018

Copy link
Copy Markdown
Author

@Narvalex Thanks for your question. You can see the comment here: https://github.com/EventStore/ClientAPI.NetCore/blob/master/src/EventStore.ClientAPI.NetCore/ExpectedVersion.cs#L13 which obviously claims something different then the code, and second, you can check the server implementation here: https://github.com/EventStore/EventStore/blob/master/src/EventStore.Core/Data/ExpectedVersion.cs
On the other hand, at the server side this value is commented out, see https://github.com/EventStore/EventStore/blob/master/src/EventStore.Core/Data/ExpectedVersion.cs#L7.

@Narvalex

Narvalex commented Jul 9, 2018

Copy link
Copy Markdown

You are right, @prolic ! thanks for your kind response. I didn't see that the NoStream constant (-1) is still there. I was worry it will break my event sourcing framework library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.