This repository was archived by the owner on May 25, 2023. It is now read-only.
Support Weight for NodeOrder Plugin #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k82cn
reviewed
Mar 13, 2019
| } | ||
|
|
||
| // Checks whether podaffinity.weight is provided or not, if given, modifies the value in weight struct. | ||
| if args["podaffinity.weight"] != "" { |
There was a problem hiding this comment.
move string to a const, similar comments to other.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, thandayuthapani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 28, 2019
Closed
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 29, 2019
…0-upstream-release-0.4 Automated cherry pick of #640: Support Weight for NodeOrder Plugin
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Support Weight for NodeOrder Plugin
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Support Weight for NodeOrder Plugin
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Support Weight for NodeOrder Plugin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: thandayuthapani thandayuthapani.s@huawei.com
What this PR does / why we need it:
Added Support for Weight in NodeOrder Plugin