Manual cherrypick master branch changes to release-9.0#752
Merged
k8s-ci-robot merged 5 commits intoFeb 8, 2019
Merged
Manual cherrypick master branch changes to release-9.0#752k8s-ci-robot merged 5 commits into
k8s-ci-robot merged 5 commits into
Conversation
Member
Author
|
/assign @yliaog |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes in master branch got dropped by
git pull -s ourswhen we merge master branch into release-9.0: #751basically the 14th commit (
"Merge branch 'master' of github.com:kubernetes-client/python into re") in https://github.com/kubernetes-client/python/pull/751/commits is empty, which means the 1~13 commits didn't get into release-9.0this PR manually cherrypicked the 1~13 commits from https://github.com/kubernetes-client/python/pull/751/commits into release-9.0 branch to make sure the changes will be included in 9.0.0b1
double checked the version constants and ran the script to re-generate the client. confirmed that nothing changes