Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release-1.20] Make autoscaler instrument async so we can remove metric attributes when revisions go away#16302

Merged
knative-prow[bot] merged 2 commits intoknative:release-1.20knative/serving:release-1.20from
knative-prow-robot:cherry-pick-16300-to-release-1.20knative-prow-robot/serving:cherry-pick-16300-to-release-1.20Copy head branch name to clipboard
Dec 17, 2025
Merged

[release-1.20] Make autoscaler instrument async so we can remove metric attributes when revisions go away#16302
knative-prow[bot] merged 2 commits intoknative:release-1.20knative/serving:release-1.20from
knative-prow-robot:cherry-pick-16300-to-release-1.20knative-prow-robot/serving:cherry-pick-16300-to-release-1.20Copy head branch name to clipboard

Conversation

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot commented Dec 11, 2025

This is an automated cherry-pick of #16300

autoscaler - switch to async metric instrumentation to avoid unbounded memory growth

@knative-prow knative-prow Bot requested review from dsimansk, linkvt and skonto December 11, 2025 19:24
@knative-prow knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 11, 2025
@dprotaso
Copy link
Copy Markdown
Member

/hold

want to get an end-user to verify the patch

@knative-prow knative-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 94.07407% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.02%. Comparing base (2f3129a) to head (9b85f15).
⚠️ Report is 3 commits behind head on release-1.20.

Files with missing lines Patch % Lines
pkg/autoscaler/scaling/metrics.go 94.02% 4 Missing ⚠️
pkg/autoscaler/scaling/autoscaler.go 80.00% 2 Missing ⚠️
pkg/reconciler/autoscaling/kpa/metrics.go 93.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.20   #16302      +/-   ##
================================================
- Coverage         80.05%   80.02%   -0.04%     
================================================
  Files               214      214              
  Lines             13281    13310      +29     
================================================
+ Hits              10632    10651      +19     
- Misses             2291     2299       +8     
- Partials            358      360       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Copy Markdown
Member

/retest

@dprotaso
Copy link
Copy Markdown
Member

/hold cancel

@knative-prow knative-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2025
@dprotaso
Copy link
Copy Markdown
Member

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2025
@knative-prow knative-prow Bot merged commit bdc2fd9 into knative:release-1.20 Dec 17, 2025
156 of 157 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.