Exposed method to send Ping and Event to be notified when Pong is received - #44
#44Open
lineker wants to merge 1 commit into
Open
Exposed method to send Ping and Event to be notified when Pong is received#44lineker wants to merge 1 commit into
lineker wants to merge 1 commit into
Conversation
Owner
|
This change looks good, but it will break the existing API (data received event). So probably I cannot merge it for now. You'd better break it into two PRs, then I can only merge the one about pong event. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a method to send a ping and a new event that is raised when a Pong is received.
I wasn't able to build for Android and iOS because I don't have a license at the moment.