Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 367fe0b

Browse filesBrowse files
committed
Merge remote-tracking branch 'cyberalien/ticket/10350' into develop
* cyberalien/ticket/10350: [ticket/10350] Script for testing eval renderer [ticket/10350] Fix for class phpbb_template_renderer_eval
2 parents bbb10f5 + d8f4f92 commit 367fe0b
Copy full SHA for 367fe0b

2 files changed

+32-1Lines changed: 32 additions & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎phpBB/includes/template/renderer_eval.php‎

Copy file name to clipboardExpand all lines: phpBB/includes/template/renderer_eval.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@ public function render($context, $lang)
5555
$_rootref = &$context->get_root_ref();
5656
$_lang = $lang;
5757

58-
eval($this->code);
58+
eval(' ?>' . $this->code . '<?php ');
5959
}
6060
}
Collapse file
+31Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
<?php
2+
/**
3+
*
4+
* @package testing
5+
* @copyright (c) 2011 phpBB Group
6+
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
7+
*
8+
*/
9+
10+
class phpbb_template_renderer_eval_test extends phpbb_test_case
11+
{
12+
public function test_eval()
13+
{
14+
$compiled_code = '<a href="<?php echo \'Test\'; ?>">';
15+
$valid_code = '<a href="Test">';
16+
$context = new phpbb_template_context();
17+
$template = new phpbb_template_renderer_eval($compiled_code, NULL);
18+
ob_start();
19+
try
20+
{
21+
$template->render($context, array());
22+
}
23+
catch (Exception $exception)
24+
{
25+
ob_end_clean();
26+
throw $exception;
27+
}
28+
$output = ob_get_clean();
29+
$this->assertEquals($valid_code, $output);
30+
}
31+
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.