Remove blanket outputDirectoryCreator from SuiteEngineTests#5793
Merged
mpkorstanje merged 1 commit intoJun 23, 2026
mainjunit-team/junit-framework:mainfrom
rien/narrow-single-test-test-casejunit-team/junit-framework:rien/narrow-single-test-test-caseCopy head branch name to clipboard
Merged
Remove blanket outputDirectoryCreator from SuiteEngineTests#5793mpkorstanje merged 1 commit intomainjunit-team/junit-framework:mainfrom rien/narrow-single-test-test-casejunit-team/junit-framework:rien/narrow-single-test-test-caseCopy head branch name to clipboard
mpkorstanje merged 1 commit into
mainjunit-team/junit-framework:mainfrom
rien/narrow-single-test-test-casejunit-team/junit-framework:rien/narrow-single-test-test-caseCopy head branch name to clipboard
Conversation
mpkorstanje
force-pushed
the
rien/narrow-single-test-test-case
branch
from
June 23, 2026 13:57
870a84c to
0d0b617
Compare
The output directory is only needed for the `passesOutputDirectoryCreatorToEnginesInSuite`, but because that test uses the `SelectClassesSuite` every other test also needed to set the output directory. This makes the tests larger than strictly necessary. By removing the `TestReporter` from the `SingleTestTestCase` and adding a dedicated `SingleTestWithTestReporterTestCase` we can make all the suite tests a bit more focused.
mpkorstanje
force-pushed
the
rien/narrow-single-test-test-case
branch
from
June 23, 2026 14:04
0d0b617 to
44a5144
Compare
✅ All tests passed ✅🏷️ Commit: 44a5144 Learn more about TestLens at testlens.app. |
marcphilipp
pushed a commit
that referenced
this pull request
Jul 12, 2026
The output directory is only needed for the `passesOutputDirectoryCreatorToEnginesInSuite`, but because that test uses the `SelectClassesSuite` every other test also needed to set the output directory. This makes the tests larger than strictly necessary. By removing the `TestReporter` from the `SingleTestTestCase` and adding a dedicated `SingleTestWithTestReporterTestCase` we can make all the suite tests a bit more focused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output directory is only needed for the
passesOutputDirectoryCreatorToEnginesInSuitetest, but because that test uses theSelectClassesSuiteevery other test also needed to set the output directory. This makes the tests larger than strictly necessary.By removing the
TestReporterfrom theSingleTestTestCaseand adding a dedicatedSingleTestWithTestReporterTestCasewe can make all the suite tests a bit more focused.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations