expose string.js as AMD#20
Closed
eduardo-matos wants to merge 2 commits into
Closed
expose string.js as AMD#20eduardo-matos wants to merge 2 commits into
eduardo-matos wants to merge 2 commits into
Conversation
Owner
|
Merging code locally. Will be updated shortly. |
|
Hey, is anyone still around? I'm still using StringJS, and would like to use it as an AMD module with RequireJS. However, the code in this AMD-enabled commit is about 700 lines of code, whereas the master (v. 3.3.3, which I'm using now) is more like 1100 lines, making me think it's more modern. Is there an AMD-enabled version anywhere that's also got the latest-greatest StringJS code/feature-set? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for AMD.
I've manually tested this feature with RequireJS and Dojo Toolkit, and everything worked as expected.
I'd be glad if you help me to test this! 😅