Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 10, 2021. It is now read-only.

feat: Fill to brim#26

Open
Kalaiz wants to merge 2 commits into
john990:masterjohn990/WaveView:masterfrom
Kalaiz:feat-fill-to-brimKalaiz/WaveView:feat-fill-to-brimCopy head branch name to clipboard
Open

feat: Fill to brim#26
Kalaiz wants to merge 2 commits into
john990:masterjohn990/WaveView:masterfrom
Kalaiz:feat-fill-to-brimKalaiz/WaveView:feat-fill-to-brimCopy head branch name to clipboard

Conversation

@Kalaiz

@Kalaiz Kalaiz commented Feb 21, 2021

Copy link
Copy Markdown
  • Allows users to let the view fill to the brim on their discretion via the newly created boolean attribute: fill_to_brim.

Users alter this feature like this:
. . .
wave:wave_length="middle"
wave:fill_to_brim="true" />

feat: Fill to brim    
- Current implementation does not give an option to fill the view till the brim, hence, I added a feature to allow users to let the view fill to the brim on their discretion via the newly created boolean attribute: `fill_to_brim`

chore: Includes Gradle update done in  john990#25

chore: README update
- Badge fix from john990#25 and code update based on this feature
@Kalaiz
Kalaiz marked this pull request as ready for review February 21, 2021 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.