Jetty 12.1 http1 cleanups#15470
Draft
gregw wants to merge 7 commits into
jetty-12.1.xjetty/jetty.project:jetty-12.1.xfrom
jetty-12.1-http1-cleanupsjetty/jetty.project:jetty-12.1-http1-cleanupsCopy head branch name to clipboard
Draft
Jetty 12.1 http1 cleanups#15470gregw wants to merge 7 commits intojetty-12.1.xjetty/jetty.project:jetty-12.1.xfrom jetty-12.1-http1-cleanupsjetty/jetty.project:jetty-12.1-http1-cleanupsCopy head branch name to clipboard
gregw wants to merge 7 commits into
jetty-12.1.xjetty/jetty.project:jetty-12.1.xfrom
jetty-12.1-http1-cleanupsjetty/jetty.project:jetty-12.1-http1-cleanupsCopy head branch name to clipboard
Conversation
…nce: volatile: ``` Benchmark (hits) Mode Cnt Score Error Units HttpParseBenchmark.testLookAhead 100 thrpt 10 258037129.985 ± 6244505.876 ops/s HttpParseBenchmark.testLookAhead 10 thrpt 10 24060672.303 ± 296570.615 ops/s HttpParseBenchmark.testLookAhead 1 thrpt 10 24509531.408 ± 252538.339 ops/s HttpParseBenchmark.testLookAhead 0 thrpt 10 25840884.479 ± 402577.664 ops/s HttpParseBenchmark.testParse 100 thrpt 10 24431986.804 ± 230832.081 ops/s HttpParseBenchmark.testParse 10 thrpt 10 22802546.443 ± 1109027.149 ops/s HttpParseBenchmark.testParse 1 thrpt 10 23111702.171 ± 181907.514 ops/s HttpParseBenchmark.testParse 0 thrpt 10 24215943.417 ± 467351.793 ops/s ``` without: ``` Benchmark (hits) Mode Cnt Score Error Units HttpParseBenchmark.testLookAhead 100 thrpt 10 262099341.862 ± 1079135.773 ops/s HttpParseBenchmark.testLookAhead 10 thrpt 10 25721422.285 ± 90183.195 ops/s HttpParseBenchmark.testLookAhead 1 thrpt 10 24184998.894 ± 503226.305 ops/s HttpParseBenchmark.testLookAhead 0 thrpt 10 25838321.931 ± 333850.519 ops/s HttpParseBenchmark.testParse 100 thrpt 10 25043859.336 ± 308036.951 ops/s HttpParseBenchmark.testParse 10 thrpt 10 23096332.186 ± 428675.570 ops/s HttpParseBenchmark.testParse 1 thrpt 10 23512370.456 ± 234577.879 ops/s HttpParseBenchmark.testParse 0 thrpt 10 23794430.570 ± 461529.625 ops/s ```
… and unnecessary wrapping
Contributor
Author
|
@joakime Can you look at the recording of compliance failures in this PR. Some are recorded if they are allowed, others if they are not, and other both. Should we just always record? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several cleanups of HttpParser to improve performance: