Skip to content

Navigation Menu

Sign in
Appearance settings
Sign in
Sign up
Appearance settings

fix(query): honor the "All Queries" export option on the Saved Queries tab #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paustint wants to merge 1 commit into
base: main
Choose a base branch
Loading
from
Open

fix(query): honor the "All Queries" export option on the Saved Queries tab #2018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions 14 libs/shared/ui-core/src/query/QueryHistory/QueryHistoryExportPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { QueryHistoryItem, SalesforceOrgUi } from '@jetstream/types';
import { Icon, Popover, PopoverRef, Radio, RadioGroup } from '@jetstream/ui';
import { getDexieDb, withReopenOnDatabaseClosed } from '@jetstream/ui/db';
import isDate from 'lodash/isDate';
import { FunctionComponent, useRef, useState } from 'react';
import { FunctionComponent, useEffect, useRef, useState } from 'react';
import { useAmplitude } from '../..';

type ExportScope = 'ALL' | 'CURRENT';
Expand All @@ -21,20 +21,22 @@ export const QueryHistoryExportPopover: FunctionComponent<QueryHistoryExportPopo
const popoverRef = useRef<PopoverRef>(null);
const { trackEvent } = useAmplitude();
const [exportScope, setExportScope] = useState<ExportScope>('ALL');
const [exportType, setExportType] = useState<ExportType>('ALL');
const [exportType, setExportType] = useState<ExportType>(() => (whichType === 'SAVED' ? 'FAVORITES' : 'ALL'));
const [isExporting, setIsExporting] = useState(false);

// Default the query selection to match the active tab, the user can still choose either option before exporting
useEffect(() => {
setExportType(whichType === 'SAVED' ? 'FAVORITES' : 'ALL');
}, [whichType]);

async function handleExport() {
setIsExporting(true);
try {
// Build filter function based on export type and which type
// Build filter function based on the selected options
const filterFn = (item: QueryHistoryItem) => {
if (exportScope === 'CURRENT' && item.org !== selectedOrg.uniqueId) {
return false;
}
if (whichType === 'SAVED' && !item.isFavorite) {
return false;
}
if (exportType === 'FAVORITES' && !item.isFavorite) {
return false;
}
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.