Remove modifiers from keybinding - #5588
#5588Merged
stefanhaller merged 2 commits intoMay 6, 2026
masterjesseduffield/lazygit:masterfrom
remove-modifiers-from-keybindingjesseduffield/lazygit:remove-modifiers-from-keybindingCopy head branch name to clipboard
Merged
Remove modifiers from keybinding#5588stefanhaller merged 2 commits intomasterjesseduffield/lazygit:masterfrom remove-modifiers-from-keybindingjesseduffield/lazygit:remove-modifiers-from-keybindingCopy head branch name to clipboard
stefanhaller merged 2 commits into
masterjesseduffield/lazygit:masterfrom
remove-modifiers-from-keybindingjesseduffield/lazygit:remove-modifiers-from-keybindingCopy head branch name to clipboard
Conversation
I noticed that it compares key.keyName and key.str separately instead of calling key.Equals, but instead of deciding whether that's a problem, just delete the function when nobody needs it.
Modifiers were moved into Key in 22169e2, but the separate Modifier field on types.Binding and gocui.keybinding was left behind. The keypress matcher already compares modifiers via Key.Equals, so the old field is never read on the dispatch path; it just got passed through SetKeybinding and stored. Drop it from gocui.keybinding, types.Binding, and the SetKeybinding / DeleteKeybinding signatures, and remove every now-redundant Modifier: gocui.ModNone struct field. Mouse bindings keep their own Modifier (on ViewMouseBinding) since that path still consults it.
stefanhaller
enabled auto-merge
May 6, 2026 07:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #5563; I forgot to do this there.