Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

imp: 1-js/07-object-properties/02-property-accessors/article.md#993

Merged
leviding merged 1 commit into
javascript-tutorial:masterjavascript-tutorial/zh.javascript.info:masterfrom
Dangdtx:patch-1Dangdtx/zh.javascript.info:patch-1Copy head branch name to clipboard
Feb 4, 2022
Merged

imp: 1-js/07-object-properties/02-property-accessors/article.md#993
leviding merged 1 commit into
javascript-tutorial:masterjavascript-tutorial/zh.javascript.info:masterfrom
Dangdtx:patch-1Dangdtx/zh.javascript.info:patch-1Copy head branch name to clipboard

Conversation

@Dangdtx

@Dangdtx Dangdtx commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

Getter ----->getter

目标章节:例如 1-js/01-getting-started/1-intro

当前上游最新 commit:此处填写本项目英文版 https://github.com/javascript-tutorial/en.javascript.info 的最新 commit,例如 b03ca00

**本 PR 所做更改如下:Getter ----->getter 将Getter修改为getter

文件名 参考上游 commit 更改(理由)
article.md a23882d 修改部分错误

注意,参考上游 commit 是指你所修改的文件,在英文仓库中同名文件的对应 commit,即你此次提交的修改的依据。如果本 PR 你只是提交一个文字或者语句优化,并非根据上游英文仓库的修改而提交的更新,则请填无。

Getter ----->getter
@CLAassistant

CLAassistant commented Jan 14, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@songhn233 songhn233 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为什么要修改成小写呢

@Dangdtx

Dangdtx commented Jan 16, 2022

Copy link
Copy Markdown
Contributor Author

这里为什么要修改成小写呢

外文网站首字母大写 翻译到中文网站不应该入乡随俗么 会不会有一定的歧义 属性访问器是Getter

@songhn233

Copy link
Copy Markdown
Member

外文网站首字母大写 翻译到中文网站不应该入乡随俗么 会不会有一定的歧义 属性访问器是Getter

大写的 Getter 会造成歧义嘛,能否详细一点。

看了下 MDN 的中文翻译也有 类似的。我理解如果这个大小写需要去修改的话整个教程其他地方的类似场景都需要一起修改?

@leviding

leviding commented Feb 4, 2022

Copy link
Copy Markdown
Member

我认为这里改不改都无伤大雅,提了就改了吧

@leviding leviding changed the title Update article.md fix: 1-js/07-object-properties/02-property-accessors/article.md Feb 4, 2022
@leviding leviding changed the title fix: 1-js/07-object-properties/02-property-accessors/article.md imp: 1-js/07-object-properties/02-property-accessors/article.md Feb 4, 2022
@leviding leviding merged commit 6b2e887 into javascript-tutorial:master Feb 4, 2022
@leviding leviding added DONE and removed needs +1 labels Feb 4, 2022
@Dangdtx Dangdtx deleted the patch-1 branch February 4, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.