Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: translation in 1-js/11-async/01-callbacks/article.md#985

Merged
leviding merged 1 commit into
javascript-tutorial:masterjavascript-tutorial/zh.javascript.info:masterfrom
ZhaoTim:patch-4ZhaoTim/zh.javascript.info:patch-4Copy head branch name to clipboard
Dec 29, 2021
Merged

fix: translation in 1-js/11-async/01-callbacks/article.md#985
leviding merged 1 commit into
javascript-tutorial:masterjavascript-tutorial/zh.javascript.info:masterfrom
ZhaoTim:patch-4ZhaoTim/zh.javascript.info:patch-4Copy head branch name to clipboard

Conversation

@ZhaoTim

@ZhaoTim ZhaoTim commented Dec 27, 2021

Copy link
Copy Markdown
Contributor

目标章节:例如 1-js/01-getting-started/1-intro

当前上游最新 commit:此处填写本项目英文版 https://github.com/javascript-tutorial/en.javascript.info 的最新 commit,例如 b03ca00

本 PR 所做更改如下:

文件名 参考上游 commit 更改(理由)
article.md a23882d 使更通顺

注意,参考上游 commit 是指你所修改的文件,在英文仓库中同名文件的对应 commit,即你此次提交的修改的依据。如果本 PR 你只是提交一个文字或者语句优化,并非根据上游英文仓库的修改而提交的更新,则请填无。

@ZhaoTim

ZhaoTim commented Dec 27, 2021

Copy link
Copy Markdown
Contributor Author

其实我蛮好奇,是如何看待这种只修改两个字的PR的?
👁

@leviding leviding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@leviding leviding merged commit f926abb into javascript-tutorial:master Dec 29, 2021
@leviding leviding added DONE and removed needs +1 labels Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.