Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: touch-events should be touch-action#980

Merged
leviding merged 1 commit into
javascript-tutorial:masterjavascript-tutorial/zh.javascript.info:masterfrom
justforuse:patch-2justforuse/zh.javascript.info:patch-2Copy head branch name to clipboard
Dec 22, 2021
Merged

fix: touch-events should be touch-action#980
leviding merged 1 commit into
javascript-tutorial:masterjavascript-tutorial/zh.javascript.info:masterfrom
justforuse:patch-2justforuse/zh.javascript.info:patch-2Copy head branch name to clipboard

Conversation

@justforuse

Copy link
Copy Markdown
Contributor

目标章节:例如 1-js/01-getting-started/1-intro

当前上游最新 commit:此处填写本项目英文版 https://github.com/javascript-tutorial/en.javascript.info 的最新 commit,例如 b03ca00

本 PR 所做更改如下:

文件名 参考上游 commit 更改(理由)
article.md a23882d 修改部分错误

注意,参考上游 commit 是指你所修改的文件,在英文仓库中同名文件的对应 commit,即你此次提交的修改的依据。如果本 PR 你只是提交一个文字或者语句优化,并非根据上游英文仓库的修改而提交的更新,则请填无。

@CLAassistant

CLAassistant commented Dec 16, 2021

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@xuesongde

xuesongde commented Dec 16, 2021 via email

Copy link
Copy Markdown

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢指正!

指针事件是鼠标事件的拓展。我们可以在事件名称中用 `pointer` 替换 `mouse` 来让我们的代码既能继续支持鼠标,也能更好地支持其他类型的设备。

对于浏览器可能会决定进行劫持并自行处理的拖放和复杂的触控交互 —— 请记住取消事件的默认操作,并在 CSS 中为涉及到的元素设置 `touch-events: none`。
对于浏览器可能会决定进行劫持并自行处理的拖放和复杂的触控交互 —— 请记住取消事件的默认操作,并在 CSS 中为涉及到的元素设置 `touch-action: none`。

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

放一下原文供参考:

For drag'n'drops and complex touch interactions that the browser may decide to hijack and handle on its own - remember to cancel the default action on events and set touch-action: none in CSS for elements that we engage.

@ghost ghost closed this Dec 19, 2021
@justforuse

Copy link
Copy Markdown
Contributor Author

hi,这个为啥关了呀😅

@ghost

ghost commented Dec 21, 2021

Copy link
Copy Markdown

不好意思 好像 merge 失败了,重新打开

@ghost ghost reopened this Dec 21, 2021

@leviding leviding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@leviding leviding changed the title Typo: touch-events should be touch-action fix: touch-events should be touch-action Dec 22, 2021
@leviding leviding merged commit 3f45ad9 into javascript-tutorial:master Dec 22, 2021
@leviding leviding added DONE and removed needs +1 labels Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.