Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix domainLock in SVG - issue #273#274

Merged
sanex3339 merged 5 commits into
javascript-obfuscator:masterjavascript-obfuscator/javascript-obfuscator:masterfrom
srguiwiz:fix-issue-273srguiwiz/javascript-obfuscator:fix-issue-273Copy head branch name to clipboard
Jun 6, 2018
Merged

Fix domainLock in SVG - issue #273#274
sanex3339 merged 5 commits into
javascript-obfuscator:masterjavascript-obfuscator/javascript-obfuscator:masterfrom
srguiwiz:fix-issue-273srguiwiz/javascript-obfuscator:fix-issue-273Copy head branch name to clipboard

Conversation

@srguiwiz

@srguiwiz srguiwiz commented Jun 4, 2018

Copy link
Copy Markdown
Contributor

Also have verified it really fixes the issue.

@coveralls

coveralls commented Jun 4, 2018

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 98.002% when pulling 41d3da1 on srguiwiz:fix-issue-273 into 1d9d784 on javascript-obfuscator:master.

@sanex3339

Copy link
Copy Markdown
Member

Awesome. Will merge it later today.

@sanex3339

Copy link
Copy Markdown
Member

});
});

describe('Variant #6: current hostname matches with `domainsString`', () => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong ordering. #6 before #5

@sanex3339

Copy link
Copy Markdown
Member

Hi. Resolve conflicts and i will merge it.

@srguiwiz

srguiwiz commented Jun 6, 2018

Copy link
Copy Markdown
Contributor Author

The improved code in tests better reflects browsers.

@sanex3339
sanex3339 merged commit 259e835 into javascript-obfuscator:master Jun 6, 2018
@sanex3339

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.