This repository was archived by the owner on May 28, 2018. It is now read-only.
JerseyUriBuilder: allow template parameter regexes to contain braces#3797
Open
cky wants to merge 1 commit into
javaee:masterjavaee/jersey:masterfrom
cky:allow-braces-in-template-param-regexescky/jersey:allow-braces-in-template-param-regexesCopy head branch name to clipboard
Open
JerseyUriBuilder: allow template parameter regexes to contain braces#3797cky wants to merge 1 commit intojavaee:masterjavaee/jersey:masterfrom cky:allow-braces-in-template-param-regexescky/jersey:allow-braces-in-template-param-regexesCopy head branch name to clipboard
cky wants to merge 1 commit into
javaee:masterjavaee/jersey:masterfrom
cky:allow-braces-in-template-param-regexescky/jersey:allow-braces-in-template-param-regexesCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template parameter syntax allows the regex to have one level of braces, as long as they are evenly matched, arbitrarily many times.
However,
JerseyUriBuilderdoes not currently handle this correctly: all the non-URL-safe characters (such as backslashes) after the first closing brace gets encoded, making the regex unable to be compiled successfully.