This repository was archived by the owner on May 28, 2018. It is now read-only.
Fix Jetty context path#3786
Open
brettkail-wk wants to merge 1 commit into
javaee:masterjavaee/jersey:masterfrom
brettkail-wk:jetty-uri-contextbrettkail-wk/jersey:jetty-uri-contextCopy head branch name to clipboard
Open
Fix Jetty context path#3786brettkail-wk wants to merge 1 commit intojavaee:masterjavaee/jersey:masterfrom brettkail-wk:jetty-uri-contextbrettkail-wk/jersey:jetty-uri-contextCopy head branch name to clipboard
brettkail-wk wants to merge 1 commit into
javaee:masterjavaee/jersey:masterfrom
brettkail-wk:jetty-uri-contextbrettkail-wk/jersey:jetty-uri-contextCopy head branch name to clipboard
Conversation
JettyHttpContainer has logic to support non-default context paths, but it miscalculates the request URI: the getRequestURI contains the context path, and it is appended getServerAddress(baseUri), which also (correctly) contains the context path. Use getPathInfo instead, which excludes the context path.
|
Sounds like this would fix https://github.com/jersey/jersey/issues/3338 |
Author
|
@konrader Yes, that appears to be the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JettyHttpContainerhas logic to support non-default context paths, but it miscalculates the request URI: thegetRequestURIcontains the context path, and it is appendedgetServerAddress(baseUri), which also (correctly) contains the context path. UsegetPathInfoinstead, which excludes the context path.(I am listed for Jersey in the Oracle Contributor Agreement under "Workiva Inc.")