Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix incorrect shortcut for Toggle Breakpoint.#131

Merged
ammbra merged 2 commits into
java:mainjava/devjava-content:mainfrom
mlvandijk:intellij-idea-fix-typomlvandijk/devjava-content:intellij-idea-fix-typoCopy head branch name to clipboard
Dec 16, 2024
Merged

Fix incorrect shortcut for Toggle Breakpoint.#131
ammbra merged 2 commits into
java:mainjava/devjava-content:mainfrom
mlvandijk:intellij-idea-fix-typomlvandijk/devjava-content:intellij-idea-fix-typoCopy head branch name to clipboard

Conversation

@mlvandijk

@mlvandijk mlvandijk commented Dec 14, 2024

Copy link
Copy Markdown
Contributor

Fix incorrect shortcut for Toggle Breakpoint.

Included some additional small fixes:

  • Fix spelling of "Javadoc".
  • Fix name of reader mode feature to Rendered View.
  • Grammar here and there (add/remove commas, add hyphen)

Some additional small grammar fixes.
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 14, 2024
Some additional small grammar fixes.
@JosePaumard

Copy link
Copy Markdown
Contributor

Thank you Marit, I just pushed the update on the site.

@danthe1st

danthe1st commented Dec 15, 2024

Copy link
Copy Markdown
Contributor

@JosePaumard Wouldn't it make sense to also merge it if the change is pushed to the site to make sure this repository is consistent? After all, if someone wants to fix something in this article in the future, it would be easier if they base their PR on the up-to-date version in this repository.

@ammbra ammbra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you, Marit.

@ammbra ammbra merged commit 3ee75dd into java:main Dec 16, 2024
@ammbra

ammbra commented Dec 16, 2024

Copy link
Copy Markdown
Collaborator

@danthe1st The changes reported on this repo are also merged. This has been done with past PRs as well. 😄

@mlvandijk mlvandijk deleted the intellij-idea-fix-typo branch December 16, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.