Make minor improvements to PrinterFriendlyView - #219
#219Open
mscotch1 wants to merge 1 commit into
jaltekruse:printer-friendly-viewjaltekruse/Free-Math:printer-friendly-viewfrom
mscotch1:printer-friendly-viewmscotch1/Free-Math:printer-friendly-viewCopy head branch name to clipboard
Open
Make minor improvements to PrinterFriendlyView#219mscotch1 wants to merge 1 commit intojaltekruse:printer-friendly-viewjaltekruse/Free-Math:printer-friendly-viewfrom mscotch1:printer-friendly-viewmscotch1/Free-Math:printer-friendly-viewCopy head branch name to clipboard
mscotch1 wants to merge 1 commit into
jaltekruse:printer-friendly-viewjaltekruse/Free-Math:printer-friendly-viewfrom
mscotch1:printer-friendly-viewmscotch1/Free-Math:printer-friendly-viewCopy head branch name to clipboard
Conversation
mscotch1
commented
Nov 23, 2022
- Remove ModalMenuBar from print view
- Add attribution to Free Math in the print view
- Prevent breaking problems across page boundaries
- Prevent printing more pages than needed (minHeight: "100vh" extended page too much)
- Add assignment name to print view
- Remove ModalMenuBar from print view - Add attribution to Free Math in the print view - Prevent breaking problems across page boundaries - Prevent printing more pages than needed (minHeight: "100vh" extended page too much) - Add assignment name to print view
mscotch1
marked this pull request as draft
November 23, 2022 20:04
mscotch1
marked this pull request as ready for review
November 24, 2022 16:08
Author
|
Pertains to #75 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.