[#465] introduce irods.experimental.client.http module#466
Draft
d-w-moore wants to merge 12 commits into
irods:mainirods/python-irodsclient:mainfrom
d-w-moore:prc_session_httpd-w-moore/python-irodsclient:prc_session_httpCopy head branch name to clipboard
Draft
[#465] introduce irods.experimental.client.http module#466d-w-moore wants to merge 12 commits intoirods:mainirods/python-irodsclient:mainfrom d-w-moore:prc_session_httpd-w-moore/python-irodsclient:prc_session_httpCopy head branch name to clipboard
d-w-moore wants to merge 12 commits into
irods:mainirods/python-irodsclient:mainfrom
d-w-moore:prc_session_httpd-w-moore/python-irodsclient:prc_session_httpCopy head branch name to clipboard
Conversation
irods.client.http.Session is a new way of connecting and reflects one possible future of iRODS clients, ie communicating via HTTP instead of the traditional iRODS protocol.
Member
|
experimental, .... 'above' client ? |
Member
|
and commit message to be updated/corrected once decided. |
Contributor
|
I vote for experimental being above client as well. That gives us a single namespace for any number of experimental things. We also need to include documentation that explains the purpose/goals of the experimental module. |
Collaborator
Author
|
Yes I suppose that move makes sense. |
(See Session.data_object_replicas). Also, swap the client and experimental namespaces. And rework the demo slightly.
regularize use of int and string for offset, count data_object gets one replica by default can pass genquery options to session.data_object
offset no longer used to indicate return type. len of page properly used to update offset in each call to get_r to get initial page, we can call next_page() init on returned iterator. other offsets of pages should be done Pythonically ie with itertools.islice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
irods.client.experimental.http.Session is a new way of connecting and reflects one possible future of iRODS clients, ie communicating via HTTP instead of the traditional iRODS protocol.