Refactor CallbackComponent for authoring entity management#2297
Open
SYBIOTE wants to merge 2 commits into
devir-engine/ir-engine:devfrom
IR-11497-MT-INT-Components-Trigger-values-are-not-reflected-in-the-UIir-engine/ir-engine:IR-11497-MT-INT-Components-Trigger-values-are-not-reflected-in-the-UICopy head branch name to clipboard
Open
Refactor CallbackComponent for authoring entity management#2297SYBIOTE wants to merge 2 commits intodevir-engine/ir-engine:devfrom IR-11497-MT-INT-Components-Trigger-values-are-not-reflected-in-the-UIir-engine/ir-engine:IR-11497-MT-INT-Components-Trigger-values-are-not-reflected-in-the-UICopy head branch name to clipboard
SYBIOTE wants to merge 2 commits into
devir-engine/ir-engine:devfrom
IR-11497-MT-INT-Components-Trigger-values-are-not-reflected-in-the-UIir-engine/ir-engine:IR-11497-MT-INT-Components-Trigger-values-are-not-reflected-in-the-UICopy head branch name to clipboard
Conversation
SYBIOTE
requested review from
AidanCaruso,
MbfloydIR,
MichaelEstes,
SamMazerIR and
the-reality-engineer
as code owners
July 4, 2025 22:05
…-not-reflected-in-the-UI
HexaField
reviewed
Jul 4, 2025
HexaField
left a comment
Contributor
There was a problem hiding this comment.
When/why are we adding callbacks on authoring entities? Callbacks are not serializable, therefore should not be on the authoring layer.
Contributor
Author
Hmm, all entities in the scene already have callbacks for visibility, because of the object component The trigger component I assume then we dont want absolutely any callbacks in the authoring layer |
MbfloydIR
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the CallbackComponent to utilize the authoring entity for managing callbacks, ensuring that callbacks set on the authoring entity automatically reflect in the simulation. This change enhances the consistency and reliability of callback handling.