Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: partial revert of 1be7c1a20; make traverser process identity CIDs#443

Merged
rvagg merged 1 commit intorelease/v0.14.xipfs/go-graphsync:release/v0.14.xfrom
rvagg/traverser-loads-identity-v0.14ipfs/go-graphsync:rvagg/traverser-loads-identity-v0.14Copy head branch name to clipboard
Sep 21, 2023
Merged

fix: partial revert of 1be7c1a20; make traverser process identity CIDs#443
rvagg merged 1 commit intorelease/v0.14.xipfs/go-graphsync:release/v0.14.xfrom
rvagg/traverser-loads-identity-v0.14ipfs/go-graphsync:rvagg/traverser-loads-identity-v0.14Copy head branch name to clipboard

Conversation

@rvagg
Copy link
Copy Markdown
Member

@rvagg rvagg commented Sep 20, 2023

#442 for v0.14.x; needed for testing for now; will merge and release once I confirm alternative ways around this problem are straightforward.

It turns out that there are obscure cases where this matters, so we can't
as easily just ignore identity CIDs. Specifically, classic online Filecoin
deals that rely on Graphsync _and_ require identity CIDs be stored in the
CARv1 that is used to calculate CommP must see the identity CID pass through
the LinkSystem.

Unfortunately, the easiest way to deal with this is to send them over the wire
as if they are a normal block; which happens to be the "safe" backward
compatible way too. Less easy way would be to simulate it on both ends and
not send them, but we'll take the easy path for now.

Extension of tests in here to make sure that the full DAG is transferred even
in this case. Blockstore _must_ have identity CIDs in them, or be able to
respond properly to them.
@rvagg rvagg merged commit d136b82 into release/v0.14.x Sep 21, 2023
@rvagg rvagg deleted the rvagg/traverser-loads-identity-v0.14 branch September 21, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.