fix: partial revert of 1be7c1a20; make traverser process identity CIDs#442
Merged
rvagg merged 1 commit intomainipfs/go-graphsync:mainfrom Sep 21, 2023
rvagg/traverser-loads-identityipfs/go-graphsync:rvagg/traverser-loads-identityCopy head branch name to clipboard
Merged
fix: partial revert of 1be7c1a20; make traverser process identity CIDs#442rvagg merged 1 commit intomainipfs/go-graphsync:mainfrom rvagg/traverser-loads-identityipfs/go-graphsync:rvagg/traverser-loads-identityCopy head branch name to clipboard
rvagg merged 1 commit intomainipfs/go-graphsync:mainfrom
rvagg/traverser-loads-identityipfs/go-graphsync:rvagg/traverser-loads-identityCopy head branch name to clipboard
Conversation
It turns out that there are obscure cases where this matters, so we can't as easily just ignore identity CIDs. Specifically, classic online Filecoin deals that rely on Graphsync _and_ require identity CIDs be stored in the CARv1 that is used to calculate CommP must see the identity CID pass through the LinkSystem. Unfortunately, the easiest way to deal with this is to send them over the wire as if they are a normal block; which happens to be the "safe" backward compatible way too. Less easy way would be to simulate it on both ends and not send them, but we'll take the easy path for now. Extension of tests in here to make sure that the full DAG is transferred even in this case. Blockstore _must_ have identity CIDs in them, or be able to respond properly to them.
rvagg
added a commit
to filecoin-project/lassie
that referenced
this pull request
Sep 20, 2023
Ref: ipfs/go-graphsync#442 Instead of relying on the transports to do what we ask wrt identity CIDs; handle it all locally and gate their handling right up to the output block stream.
This was referenced Sep 20, 2023
rvagg
added a commit
to filecoin-project/lassie
that referenced
this pull request
Sep 21, 2023
Ref: ipfs/go-graphsync#442 Instead of relying on the transports to do what we ask wrt identity CIDs; handle it all locally and gate their handling right up to the output block stream.
rvagg
added a commit
to filecoin-project/lassie
that referenced
this pull request
Sep 21, 2023
Ref: ipfs/go-graphsync#442 Instead of relying on the transports to do what we ask wrt identity CIDs; handle it all locally and gate their handling right up to the output block stream.
parkan
pushed a commit
to parkan/sheltie
that referenced
this pull request
Dec 17, 2025
Ref: ipfs/go-graphsync#442 Instead of relying on the transports to do what we ask wrt identity CIDs; handle it all locally and gate their handling right up to the output block stream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that there are obscure cases where this matters, so we can't as easily just ignore identity CIDs. Specifically, classic online Filecoin deals that rely on Graphsync and require identity CIDs be stored in the CARv1 that is used to calculate CommP must see the identity CID pass through the LinkSystem.
Unfortunately, the easiest way to deal with this is to send them over the wire as if they are a normal block; which happens to be the "safe" backward compatible way too. Less easy way would be to simulate it on both ends and not send them, but we'll take the easy path for now.
Extension of tests in here to make sure that the full DAG is transferred even in this case. Blockstore must have identity CIDs in them, or be able to respond properly to them.