Percent encode whitespace in mailto hrefs#13197
Open
jimchamp wants to merge 1 commit into
masterinternetarchive/openlibrary:masterfrom
percent-encode-mailto-linksinternetarchive/openlibrary:percent-encode-mailto-linksCopy head branch name to clipboard
Open
Percent encode whitespace in mailto hrefs#13197jimchamp wants to merge 1 commit intomasterinternetarchive/openlibrary:masterfrom percent-encode-mailto-linksinternetarchive/openlibrary:percent-encode-mailto-linksCopy head branch name to clipboard
mailto hrefs#13197jimchamp wants to merge 1 commit into
masterinternetarchive/openlibrary:masterfrom
percent-encode-mailto-linksinternetarchive/openlibrary:percent-encode-mailto-linksCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes HTML validation issues by percent-encoding the space in mailto: href query strings (specifically the subject parameter), ensuring the generated links use a valid URI.
Changes:
- Updated the footer “Contact Us”
mailto:link to usesubject=Support%20Case. - Updated the account settings support
mailto:link to usesubject=Support%20Case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openlibrary/templates/lib/nav_foot.html | Percent-encodes the space in the mailto: subject used by the footer “Contact Us” link. |
| openlibrary/templates/account.html | Percent-encodes the space in the mailto: subject used by the account settings support link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The space character in our
mailtolinks is causing validation errors. Spaces are illegal characters forhrefvalues.Please close if not needed
Technical
Testing
Screenshot
Stakeholders