Migrate monthly logins to FastAPI#13041
Merged
RayBB merged 3 commits intoJul 1, 2026
internetarchive:masterinternetarchive/openlibrary:masterfrom
Shikhar-395:fastapi/monthly-loginsShikhar-395/openlibrary:fastapi/monthly-loginsCopy head branch name to clipboard
Merged
Migrate monthly logins to FastAPI#13041RayBB merged 3 commits intointernetarchive:masterinternetarchive/openlibrary:masterfrom Shikhar-395:fastapi/monthly-loginsShikhar-395/openlibrary:fastapi/monthly-loginsCopy head branch name to clipboard
RayBB merged 3 commits into
internetarchive:masterinternetarchive/openlibrary:masterfrom
Shikhar-395:fastapi/monthly-loginsShikhar-395/openlibrary:fastapi/monthly-loginsCopy head branch name to clipboard
Conversation
Shikhar-395
marked this pull request as ready for review
June 26, 2026 17:50
RayBB
approved these changes
Jul 1, 2026
RayBB
left a comment
Collaborator
There was a problem hiding this comment.
Great work here too. I updated the cache method so we don't need web but otherwise this was good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the monthly logins route from legacy web.py routing to FastAPI while preserving the existing admin stats JSON response shape.
Migrated endpoint:
Stakeholders
@RayBB