fix: Added default embedding model to models downloaded by default#3118
fix: Added default embedding model to models downloaded by default#3118mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
Conversation
|
You shouldn't need changes to the qna.yaml file. Those were part of #3115 |
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Thanks! I just rebased and it was removed from the PR. |
|
why not just add the |
I thought it was covered by the discussion in the related issue about |
|
I still prefer the approach I specified in the issue:
However, I understand it is debatable, and I am happy to reconsider if there is a broad consensus that this is not the right approach. |
jwm4
left a comment
There was a problem hiding this comment.
I understand there is still some disagreement about whether this is the right UX, but it is still the one I prefer so I am approving the PR.
jaideepr97
left a comment
There was a problem hiding this comment.
approving based on previously conducted discussions
booxter
left a comment
There was a problem hiding this comment.
Prefer this to adding code to handle --rag option. Especially with the other stuff going on that may affect the future of CLI.
... restricting this behavior to apply only when the feature flag for RAG is turned on ..., the embedding model is always downloaded, no matter the configuration of the feature flags.Issue resolved by this Pull Request:
Resolves #2961
Checklist:
conventional commits.