fix: Reformatted file to comply with yamllint reqs#3115
Merged
mergify[bot] merged 2 commits intoinstructlab:maininstructlab/instructlab:mainfrom Feb 3, 2025
Merged
fix: Reformatted file to comply with yamllint reqs#3115mergify[bot] merged 2 commits intoinstructlab:maininstructlab/instructlab:mainfrom
mergify[bot] merged 2 commits intoinstructlab:maininstructlab/instructlab:mainfrom
Conversation
Signed-off-by: Jiri Podivin <jpodivin@gmail.com>
Without this change the yamllint couldn't be executed in developer environment where tox was run before. Signed-off-by: Jiri Podivin <jpodivin@gmail.com>
jwm4
approved these changes
Feb 2, 2025
Contributor
jwm4
left a comment
There was a problem hiding this comment.
The change to qna.yaml looks good to me; sorry for the problem with it! I don't understand the .yamllint.yaml change, but I have no objection to it.
Contributor
|
Note that this resolves #3114 |
Contributor
Author
Basically, |
Contributor
|
That makes sense. Thx for explaining! |
nathan-weinberg
approved these changes
Feb 3, 2025
booxter
approved these changes
Feb 3, 2025
Contributor
|
thank you so much.. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes locally running newly introduced yamllint possible, while also resolving an ongoing CI issue.
Checklist:
conventional commits.