Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

fix: remove duplicate log messages in detached SDG (backport #3031)#3038

Merged
mergify[bot] merged 1 commit intorelease-v0.23instructlab/instructlab:release-v0.23from
mergify/bp/release-v0.23/pr-3031instructlab/instructlab:mergify/bp/release-v0.23/pr-3031Copy head branch name to clipboard
Jan 28, 2025
Merged

fix: remove duplicate log messages in detached SDG (backport #3031)#3038
mergify[bot] merged 1 commit intorelease-v0.23instructlab/instructlab:release-v0.23from
mergify/bp/release-v0.23/pr-3031instructlab/instructlab:mergify/bp/release-v0.23/pr-3031Copy head branch name to clipboard

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jan 28, 2025

currently, since we add a log file handler and capture the logs from the runnning process when running -dt, there are duplicate log messages. Only add the log file handler if running in attached mode

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.
This is an automatic backport of pull request #3031 done by [Mergify](https://mergify.com).

@cdoern @mergify
fix: remove duplicate log messages in detached SDG
fcc92ed 
currently, since we add a log file handler and capture the logs from the runnning process when running -dt, there are duplicate log messages. Only add the log file handler if running in attached mode

Signed-off-by: Charlie Doern <cdoern@redhat.com>
(cherry picked from commit f9090d0)
@mergify mergify bot mentioned this pull request Jan 28, 2025
Merged
6 tasks
@mergify mergify bot added the release-branch Pull Request directly to a release branch label Jan 28, 2025
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Jan 28, 2025
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Jan 28, 2025
@mergify mergify bot merged commit 020dd48 into release-v0.23 Jan 28, 2025
27 checks passed
@mergify mergify bot deleted the mergify/bp/release-v0.23/pr-3031 branch January 28, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cdoern cdoern cdoern approved these changes

@nathan-weinberg nathan-weinberg nathan-weinberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-branch Pull Request directly to a release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdoern @nathan-weinberg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.