fix: remove duplicate log messages in detached SDG#3031
Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom Jan 28, 2025
Merged
fix: remove duplicate log messages in detached SDG#3031mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
Conversation
currently, since we add a log file handler and capture the logs from the runnning process when running -dt, there are duplicate log messages. Only add the log file handler if running in attached mode Signed-off-by: Charlie Doern <cdoern@redhat.com>
alinaryan
approved these changes
Jan 28, 2025
nathan-weinberg
approved these changes
Jan 28, 2025
Member
|
@Mergifyio backport release-v0.23 |
Contributor
✅ Backports have been createdDetails
|
6 tasks
mergify bot
added a commit
that referenced
this pull request
Jan 28, 2025
…3038) currently, since we add a log file handler and capture the logs from the runnning process when running -dt, there are duplicate log messages. Only add the log file handler if running in attached mode **Checklist:** - [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Functional tests have been added, if necessary. - [ ] E2E Workflow tests have been added, if necessary. <hr>This is an automatic backport of pull request #3031 done by [Mergify](https://mergify.com). Approved-by: cdoern Approved-by: nathan-weinberg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, since we add a log file handler and capture the logs from the runnning process when running -dt, there are duplicate log messages. Only add the log file handler if running in attached mode
Checklist:
conventional commits.