Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

add a test for get_argument#2945

Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
reidliu41:add-test-for-get_argumentreidliu41/instructlab:add-test-for-get_argumentCopy head branch name to clipboard
Jan 21, 2025
Merged

add a test for get_argument#2945
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
reidliu41:add-test-for-get_argumentreidliu41/instructlab:add-test-for-get_argumentCopy head branch name to clipboard

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Jan 20, 2025

For #2939 (review)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@mergify mergify bot added the testing Relates to testing label Jan 20, 2025
@reidliu41 reidliu41 requested a review from danmcp January 21, 2025 01:17
danmcp
danmcp reviewed Jan 21, 2025
View reviewed changes
tests/test_backends.py Show resolved Hide resolved
@reidliu41
add a test for get_argument
c53c8a4 
Signed-off-by: reid_liu <guliu@redhat.com>
@reidliu41 reidliu41 force-pushed the add-test-for-get_argument branch from f0d8d4b to c53c8a4 Compare January 21, 2025 03:45
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Jan 21, 2025
@mergify mergify bot merged commit ab3828c into instructlab:main Jan 21, 2025
27 checks passed
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@danmcp danmcp danmcp approved these changes

@nathan-weinberg nathan-weinberg nathan-weinberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reidliu41 @danmcp @nathan-weinberg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.