Improvement to get_argument#2939
Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom Jan 20, 2025
reidliu41:improve-get_argumentreidliu41/instructlab:improve-get_argumentCopy head branch name to clipboard
Merged
Improvement to get_argument#2939mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom reidliu41:improve-get_argumentreidliu41/instructlab:improve-get_argumentCopy head branch name to clipboard
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
reidliu41:improve-get_argumentreidliu41/instructlab:improve-get_argumentCopy head branch name to clipboard
Conversation
Signed-off-by: reid_liu <guliu@redhat.com>
danmcp
approved these changes
Jan 19, 2025
Contributor
danmcp
left a comment
There was a problem hiding this comment.
Great change, thanks for the PR!
Would probably be good to have a test for this logic (separate PR would be fine).
nathan-weinberg
approved these changes
Jan 20, 2025
This was referenced Jan 20, 2025
mergify bot
added a commit
that referenced
this pull request
Jan 21, 2025
For #2939 (review) **Checklist:** - [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Functional tests have been added, if necessary. - [ ] E2E Workflow tests have been added, if necessary. Approved-by: danmcp Approved-by: nathan-weinberg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #2927 (comment)
Checklist:
conventional commits.