Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

fix: don't error out if serve/chat model don't match (backport #2756)#2762

Merged
mergify[bot] merged 1 commit intorelease-v0.21instructlab/instructlab:release-v0.21from
mergify/bp/release-v0.21/pr-2756instructlab/instructlab:mergify/bp/release-v0.21/pr-2756Copy head branch name to clipboard
Dec 7, 2024
Merged

fix: don't error out if serve/chat model don't match (backport #2756)#2762
mergify[bot] merged 1 commit intorelease-v0.21instructlab/instructlab:release-v0.21from
mergify/bp/release-v0.21/pr-2756instructlab/instructlab:mergify/bp/release-v0.21/pr-2756Copy head branch name to clipboard

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 6, 2024

We supply a default model to ilab model chat. If this does not match the model being served separately (if there is one), instead of erroring out we should inform the user that we are ignoring what they supplied in favor of what is being served

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.
This is an automatic backport of pull request #2756 done by [Mergify](https://mergify.com).

@jaideepr97 @mergify
fix: don't error out if serve/chat model don't match
a77d6c9 
Signed-off-by: Jaideep Rao <jrao@redhat.com>
(cherry picked from commit 0452447)
@mergify mergify bot mentioned this pull request Dec 6, 2024
Merged
6 tasks
@mergify mergify bot added testing Relates to testing release-branch Pull Request directly to a release branch labels Dec 6, 2024
@cdoern cdoern added the hold In-progress PR. Tag should be removed before merge. label Dec 6, 2024
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Dec 6, 2024
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Dec 6, 2024
@cdoern cdoern removed the hold In-progress PR. Tag should be removed before merge. label Dec 7, 2024
@mergify mergify bot merged commit 345a5b1 into release-v0.21 Dec 7, 2024
@mergify mergify bot deleted the mergify/bp/release-v0.21/pr-2756 branch December 7, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@jaideepr97 jaideepr97 jaideepr97 approved these changes

@cdoern cdoern cdoern approved these changes

@alinaryan alinaryan alinaryan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-branch Pull Request directly to a release branch testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaideepr97 @cdoern @alinaryan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.