fix: don't error out if serve/chat model don't match#2756
Merged
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom Dec 6, 2024
Merged
fix: don't error out if serve/chat model don't match#2756mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
mergify[bot] merged 1 commit intoinstructlab:maininstructlab/instructlab:mainfrom
Conversation
18f02ba to
1d326e0
Compare
cdoern
approved these changes
Dec 6, 2024
1d326e0 to
c73b4eb
Compare
Contributor
|
going to force merge this if only failure is macOS functional tests due to #2753 |
Contributor
Author
testing again |
c73b4eb to
c2619f6
Compare
Contributor
|
@Mergifyio rebase |
Signed-off-by: Jaideep Rao <jrao@redhat.com>
Contributor
✅ Branch has been successfully rebased |
Contributor
|
should fix CI |
Contributor
|
@Mergifyio backport release-v0.21 |
Contributor
✅ Backports have been createdDetails
|
6 tasks
mergify bot
added a commit
that referenced
this pull request
Dec 7, 2024
…#2762) We supply a default model to `ilab model chat`. If this does not match the model being served separately (if there is one), instead of erroring out we should inform the user that we are ignoring what they supplied in favor of what is being served **Checklist:** - [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Functional tests have been added, if necessary. - [ ] E2E Workflow tests have been added, if necessary. <hr>This is an automatic backport of pull request #2756 done by [Mergify](https://mergify.com). Approved-by: cdoern Approved-by: jaideepr97 Approved-by: alinaryan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We supply a default model to
ilab model chat. If this does not match the model being served separately (if there is one), instead of erroring out we should inform the user that we are ignoring what they supplied in favor of what is being servedChecklist:
conventional commits.