Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix building stack tool #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix building stack tool #2004

merged 1 commit into from
Jul 18, 2023

Conversation

hamishmack
Copy link
Collaborator

Avoid pantry 0.9 in versions without commercialhaskell/stack#6187

This also:

  • moves the optparse-applicative upper bound into modules/hackage-quirks.nix
  • Fixes readIfExists in modules/cabal-project.nix.
  • Removes readIfExists from lib/call-cabal-project-to-nix.nix.

Avoid pantry 0.9 in versions without commercialhaskell/stack#6187

This also:
* moves the `optparse-applicative` upper bound into `modules/hackage-quirks.nix`
* Fixes `readIfExists` in `modules/cabal-project.nix`.
* Removes `readIfExists` from `lib/call-cabal-project-to-nix.nix`.
@hamishmack hamishmack requested a review from andreabedini July 18, 2023 12:21
@hamishmack hamishmack self-assigned this Jul 18, 2023
Copy link
Member

@andreabedini andreabedini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good me 👍

@hamishmack
Copy link
Collaborator Author

Broken test is related to bump of hix default GHC in #1998

@hamishmack hamishmack merged commit b873d6f into master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.