Fix building stack projects with hix #1998
Conversation
The default compiler-nix-name provided for hix projects conflicts with the one implied by the `stack.yaml` `resolver`. Fixes #1997
| # Stack projects do not require a default as the `resolver` in the `stack.yaml` | ||
| # specifies one. | ||
| config = lib.mkIf (!config ? "stackYaml") { | ||
| compiler-nix-name = lib.mkDefault "ghc945"; |
There was a problem hiding this comment.
Wouldn't it be more straight forward to bump the priority of compiler-nix-name in the stack modules? So whatever stack.yaml says wins (perhaps still allowing user override)
There was a problem hiding this comment.
That would be nicer, but compiler-nix-name is in the project level module. I think there is a compiler.nix-name in the other modules, but we don't currently use it to set the project level compiler-nix-name (only the other way around).
Is it ok if we merge this for now and improve it if we can in the refactoring of the modules?
There was a problem hiding this comment.
Is it ok if we merge this for now and improve it if we can in the refactoring of the modules?
Sure, go head. Sorry for making you wait, I wrote that comment just as you opened the PR but I didn't realise I had "started a review" rather than "add a single comment". I'll approve now.
The default compiler-nix-name provided for hix projects conflicts with the one implied by the
stack.yamlresolver.Fixes #1997