Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Discussion options

Hi @Pointer31, @userwljs.

I see (in the network graph) that you're doing some fixes and improvements to the server.

I do not fully agree with all changes but at least some of them are very applicable to the shared codebase.

Do you want to have a place to share the code and discuss changes? I stepped away from the development but maybe I can allocate some time to review and pull fixes from your repositories. I think I also can answer your questions (if any), and shed light on some decisions and ideas, which maybe not fully implemented yet.

I see you doing some changes in somewhat suboptimal directions, e.g. I planned to move fun rounds and votes completely to Lua, and that's why there is no FunRoundsPassed management in cpp (in the context of cherry-picked userwljs/teeworlds-infclassR@d629faf).

Also there are different approaches to Witch class, and the current code might look broken.

What is your opinion on lua, survival, accounts, and 0.7 stuff? Probably it is hard to manage all the branches, and maybe I can merge some of them to make synchronization easy for you.

I'm open to eventually give permissions here on https://github.com/infclass/ if you're interested.

FYI @bretonium.

You must be logged in to vote

Replies: 3 comments

Comment options

Personally I like lua, it makes sense for map or minigame scripts especially and I already know the language. I like playing against bots in survival too though I don't really have any plans for changing it. I am not sure whether I would use an account system, though I'm not against it either as long as it's optional. Recently, I started liking 0.7 for some reason. I saw there was a base for sixup and thus I tried seeing if I could get it working. And while there aren't exactly many players, there do still seem to be a few 0.7 players and I felt like coding it anyway. I think it's decent now, though not perfect either yet.

It'd indeed be nice if some of the general fixes could be merged into the upstream. I don't really have much experience with it, but I guess I could maybe make pull requests or something?

You must be logged in to vote
0 replies
Comment options

I would be happy to contribute some fixes and i18n work upstream (it seems the current i18n has not been maintained for quite some time).

Survival mode is very popular in China; although my server is not registered with the master server, it still has a stable player base, and I have done some modding on it. As for Lua, I personally believe it should only be used within a well-defined scope; otherwise, it can introduce additional complexity and issues—for example, I once caught a heap use-after-free caused by the Lua scripts.

You must be logged in to vote
0 replies
Comment options

I am not opposed to Lua; the current implementation of Lua performs well in certain scenarios.

You must be logged in to vote
0 replies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.