Added database connection example to Singleton pattern#3451
Open
MADHURI-HS wants to merge 1 commit into
iluwatar:masteriluwatar/java-design-patterns:masterfrom
MADHURI-HS:improve-readmeMADHURI-HS/java-design-patterns:improve-readmeCopy head branch name to clipboard
Open
Added database connection example to Singleton pattern#3451MADHURI-HS wants to merge 1 commit intoiluwatar:masteriluwatar/java-design-patterns:masterfrom MADHURI-HS:improve-readmeMADHURI-HS/java-design-patterns:improve-readmeCopy head branch name to clipboard
MADHURI-HS wants to merge 1 commit into
iluwatar:masteriluwatar/java-design-patterns:masterfrom
MADHURI-HS:improve-readmeMADHURI-HS/java-design-patterns:improve-readmeCopy head branch name to clipboard
Conversation
PR SummaryExpanded the Singleton pattern documentation by adding a real-world example: database connection management. The README now highlights using a single shared instance to manage database connections and clarifies when the Singleton pattern is appropriate. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- d2a8516: Added database connection example to Singleton pattern
Files Processed (1)
- singleton/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
singleton/README.md [81-81]
best_practice: "Clarify DB usage pattern for Singleton example"
|
|
This PR is stale because it has been open 60 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an additional real-world example for the Singleton pattern.
This improves clarity by including database connection management as a practical use case.