Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

igraphmodule_Graph_dominator always boxes returned ints and doesn't expose all C function outputs #853

Copy link
Copy link

Description

@dcolascione
Issue body actions

Describe the bug

The igraphmodule_Graph_dominator shouldn't box its return values in Python ints. I generally prefer to use graph libraries in such a way that there's no direct relationship between the size of my data set and the number of Python heap objects I have to allocate. Additionally, the underlying C function is capable of returning three outputs (a graph and a list of nodes left out), and the Python binding ignores all of them except the dominator list.

Expected behavior

The function should have a parameter that asks it to return some kind of Python-buffer-protocol-supporting object allowing for batch extraction of the dominator list.

Current behavior

Returns list[int]

Version information

Mainline.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.