Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Support PHP 8.5#404

Merged
tricky merged 18 commits into
igbinary:masterigbinary/igbinary:masterfrom
thecaliskan:php-8-5-trickythecaliskan/igbinary:php-8-5-trickyCopy head branch name to clipboard
Nov 26, 2025
Merged

Support PHP 8.5#404
tricky merged 18 commits into
igbinary:masterigbinary/igbinary:masterfrom
thecaliskan:php-8-5-trickythecaliskan/igbinary:php-8-5-trickyCopy head branch name to clipboard

Conversation

@thecaliskan

@thecaliskan thecaliskan commented Oct 20, 2025

Copy link
Copy Markdown

No description provided.

tricky and others added 18 commits October 5, 2025 18:46
@tricky
Prepare for 3.2.17 release
e5c366a
@tricky
Allow for alpha/beta/rc dockerized testing
21028ea 
If the provided php version is an alpha, beta or RC version use that
exact version as docker images. Only stable releases have short tags.

Fix valgrind docker image builds for 7.1 and 7.2. These use debian
buster and the buster repo is archived.
@tricky
Missed valgrind docker image versioning.
aa44f33
@tricky
Windows 2019 to 2022
b28913d
@thecaliskan
removed unnecessary if for php 7.0
b9f1836
@thecaliskan
removed unnecessary if for php 7.0
c9ed291
@thecaliskan
removed unnecessary if for php 7.0
616c2de
@thecaliskan
removed unnecessary if for php 7.0
d2462fe
@thecaliskan
removed unnecessary if for php 7.0
b6032f7
@thecaliskan
removed unnecessary if for php 7.0
dca93ae
@thecaliskan
removed unnecessary if for php 7.0
e8e1f78
@thecaliskan
removed unnecessary if for php 7.0
515ee49
@thecaliskan
removed unnecessary if for php 7.0
c01ccb2
@thecaliskan
removed unnecessary if for php 7.0
97ac93f
@thecaliskan
removed unnecessary if for php 7.0
be5edc6
@thecaliskan
removed unnecessary if for php 7.0
19e8884
@thecaliskan
Update adjust-debian-apt-sources.sh
6e21252
@thecaliskan
Update Dockerfile.valgrind
1e33455
@thecaliskan

thecaliskan commented Oct 21, 2025

Copy link
Copy Markdown
Author

Hi @tricky, Could you give an estimated time for this PR to merge?

@thecaliskan

thecaliskan commented Nov 10, 2025

Copy link
Copy Markdown
Author

Hi @TysonAndre, I hope you are doing well. When you have a moment, Could you check PR?

@heddn

heddn commented Nov 20, 2025

Copy link
Copy Markdown

I'm attempting to build from scratch igbinary on top of RC5 of PHP 8.5 and failing miserably. Hopefully once this gets merged, that will go better.

20.85 creating libtool
20.86 appending configuration tag "CXX" to libtool
20.87 
20.87 Generating files
20.89 configure: creating build directories
20.90 configure: creating Makefile
20.91 configure: patching config.h.in
20.91 configure: creating ./config.status
20.96 config.status: creating config.h
20.99 /bin/bash /tmp/igbinary/libtool --tag=CC --mode=compile cc -I. -I/tmp/igbinary -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib  -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H  -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE   -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -Wall -Wpointer-arith -Wcast-align -Wwrite-strings -Wswitch -DZEND_COMPILE_DL_EXT=1 -c /tmp/igbinary/src/php7/igbinary.c -o src/php7/igbinary.lo  -MMD -MF src/php7/igbinary.dep -MT src/php7/igbinary.lo
21.10 mkdir src/php7/.libs
21.11  cc -I. -I/tmp/igbinary -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -Wall -Wpointer-arith -Wcast-align -Wwrite-strings -Wswitch -DZEND_COMPILE_DL_EXT=1 -c /tmp/igbinary/src/php7/igbinary.c -MMD -MF src/php7/igbinary.dep -MT src/php7/igbinary.lo  -fPIC -DPIC -o src/php7/.libs/igbinary.o
21.17 In file included from /tmp/igbinary/src/php7/igbinary.c:52:
21.17 /tmp/igbinary/src/php7/php_igbinary.h:35:10: fatal error: ext/standard/php_smart_string.h: No such file or directory
21.17    35 | #include "ext/standard/php_smart_string.h"
21.17       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
21.17 compilation terminated.
21.18 make: *** [Makefile:218: src/php7/igbinary.lo] Error 1

@thecaliskan

thecaliskan commented Nov 20, 2025

Copy link
Copy Markdown
Author

@TysonAndre @tricky

https://www.php.net/releases/8.5/en.php

@thecaliskan thecaliskan mentioned this pull request Nov 20, 2025
Merged
@kdambekalns

kdambekalns commented Nov 20, 2025

Copy link
Copy Markdown

PHP 8.5.0 has been released today, as planned. A new release of igbinary would be highly appreciated! 🫶

@tricky

tricky commented Nov 21, 2025

Copy link
Copy Markdown
Member

I will soon, what remains is completing the package.xml and such.

@GreyXor

GreyXor commented Nov 21, 2025

Copy link
Copy Markdown

I will soon, what remains is completing the package.xml and such.

Thanks!

@csandanov csandanov mentioned this pull request Nov 21, 2025
Closed
6 tasks
@thecaliskan

thecaliskan commented Nov 23, 2025

Copy link
Copy Markdown
Author

Hi @tricky, any update ?

@compwright

compwright commented Nov 25, 2025

Copy link
Copy Markdown

@tricky we eagerly await the release of this :)

@mlocati mlocati mentioned this pull request Nov 26, 2025
Closed
@Sweetchuck Sweetchuck mentioned this pull request Nov 26, 2025
Closed
@tricky tricky merged commit 45e8f00 into igbinary:master Nov 26, 2025
32 checks passed
@thecaliskan

thecaliskan commented Nov 27, 2025

Copy link
Copy Markdown
Author

https://github.com/thecaliskan/oort/actions/runs/19722076223/job/56506428787

Problem is still continue. When will the new version be released on pecl net ?

@kdambekalns

kdambekalns commented Nov 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Probably when the version is no longer an RC?

@tricky

tricky commented Nov 27, 2025

Copy link
Copy Markdown
Member

Nah, no peculiar reason, simply because I didn't upload it yesterday.
Will upload it later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thecaliskan @heddn @kdambekalns @tricky @GreyXor @compwright
Morty Proxy This is a proxified and sanitized view of the page, visit original site.