Fix #371 - lookup of pointer for typed property info is slow#372
Merged
TysonAndre merged 1 commit intoFeb 2, 2023
igbinary:masterigbinary/igbinary:masterfrom
TysonAndre:fix-371-typed-property-info-lookup-slowTysonAndre/igbinary:fix-371-typed-property-info-lookup-slowCopy head branch name to clipboard
Merged
Fix #371 - lookup of pointer for typed property info is slow#372TysonAndre merged 1 commit intoigbinary:masterigbinary/igbinary:masterfrom TysonAndre:fix-371-typed-property-info-lookup-slowTysonAndre/igbinary:fix-371-typed-property-info-lookup-slowCopy head branch name to clipboard
TysonAndre merged 1 commit into
igbinary:masterigbinary/igbinary:masterfrom
TysonAndre:fix-371-typed-property-info-lookup-slowTysonAndre/igbinary:fix-371-typed-property-info-lookup-slowCopy head branch name to clipboard
Conversation
Pointers are aligned to at least 8 bits on 64-bit systems (usually more), so there are long chains of hash collisions when inserting and looking up in ref_props.
|
This is interesting. Looks like some of my own extensions may be affected by similar issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointers are aligned to at least 8 bits on 64-bit systems (usually more), so there are long chains of hash collisions when inserting and looking up in ref_props.