Please test: OSD stats fixes and code cleanup#11506
Please test: OSD stats fixes and code cleanup#11506
Conversation
|
Test firmware build ready — commit Download firmware for PR #11506 234 targets built. Find your board's
|
|
Multi-page stats was tested using HITL (set to PAL) and single-page (HD) was tested using Avatar. Everything seems to work as expected including the Auto swap function and manual stick commands to swap pages. Would be useful for someone to test HD Zero I guess given it has less rows than Avatar. DJI WTF should be fine if Avatar works given it has more rows available. |
|
Just to provide a second opinion to what you already have. I could only test with Avatar and Analog, not HDzero. But it does seem more orderly. And the Saving Settings is not as random as it was. |
|
The OSD stats display hasn't worked correctly for HD for a while if you have stats enabled. I'm surprised nobody's mentioned it before. The disarm method was always missing and the last readable line was truncated, I assume because it was trying to write more lines after the truncated line than the display allowed which did actually cause the display to lock up for some time. This was caused by a check to see if there were enough rows available to optionally display 4 lines of stats "Totals" with the check failing because it mixed up columns with rows. There are many more columns than rows so the check always resulted in the 4 extra lines of Total stats being added when in fact there weren't enough rows available for them. Also the RX stats didn't display properly for HD using CRSF due to a mistake indicated in the 1st post above so you only got 2 out of the 3 items it was intended to display. |
Fixes the following issues related to OSD stats page display:
An issue with OSD stats not displaying properly due to a mix up with columns and rows which caused additional stats to always be added at the bottom of the screen even when there weren't enough rows available leading to display problems. See
inav/src/main/io/osd.c
Line 5432 in 76809d7
inav/src/main/io/osd.c
Line 5476 in 76809d7
An issue which prevented Rx stats being displayed correctly when CRSF used. See
inav/src/main/io/osd.c
Line 5286 in 76809d7
An issue causing unreliable "Saving Settings" messages.
In addition to the above the PR generally cleans up stats code formatting inconsistencies and layout.