Add debug_span in poll_complete loop - #764
#764Open
YHM404 wants to merge 4 commits into
hyperium:masterhyperium/h2:masterfrom
YHM404:zot6/fix-events-keep-growingYHM404/h2:zot6/fix-events-keep-growingCopy head branch name to clipboard
Open
Add debug_span in poll_complete loop#764YHM404 wants to merge 4 commits intohyperium:masterhyperium/h2:masterfrom YHM404:zot6/fix-events-keep-growingYHM404/h2:zot6/fix-events-keep-growingCopy head branch name to clipboard
YHM404 wants to merge 4 commits into
hyperium:masterhyperium/h2:masterfrom
YHM404:zot6/fix-events-keep-growingYHM404/h2:zot6/fix-events-keep-growingCopy head branch name to clipboard
Conversation
Add comment for explaining why it can fix memory leak
hawkw
reviewed
Apr 11, 2024
Member
|
It's not clear how this is an improvement, the span will still have a parent that lives a long time. However, I don't think that the parent span is a problem at all, but rather the subscriber implementation that simply grows forever. That's not h2's fault. |
Co-authored-by: Eliza Weisman <eliza@elizas.website>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #763